[m-rev.] For review: Functional forms in library/relation.m

Fergus Henderson fjh at cs.mu.OZ.AU
Wed Jan 14 16:36:13 AEDT 2004


On 14-Jan-2004, James Goddard <goddardjames at yahoo.com> wrote:
> 
> Implement functional forms of some library predicates.
> 
> library/relation.m:
> 	Implement the following functions:
> 		relation__lookup_key_set_from/2
> 		relation__lookup_key_set_to/2

That looks fine.

But that raises the question of why the compiler didn't report an error
for them not being defined.  It turns out that the reason is a bug
in the Mmakefile.

----------

Estimated hours taken: 0.25
Branches: main

library/Mmakefile:
	Fix a typo which meant that everything was always getting
	compiled with --allow-stubs --no-warn-stubs.

Index: Mmakefile
===================================================================
RCS file: /home/mercury1/repository/mercury/library/Mmakefile,v
retrieving revision 1.126
diff -u -d -u -r1.126 Mmakefile
--- Mmakefile	9 Dec 2003 15:45:06 -0000	1.126
+++ Mmakefile	14 Jan 2004 05:33:02 -0000
@@ -96,7 +96,7 @@
 # so we need to pass `--allow-stubs' to get them to compile.
 # Since the standard library is compiled with `--halt-at-warn',
 # we also need `--no-warn-stubs'.
-ifneq ("$(filter il% java%,$(GRADE)))","")
+ifneq ("$(filter il% java%,$(GRADE))","")
 MCFLAGS += --allow-stubs --no-warn-stubs
 endif
 

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list