[m-rev.] For review: Bug fix for Java grade RTTI definitions

Peter Ross pro at missioncriticalit.com
Tue Feb 24 19:08:17 AEDT 2004


On Tue, Feb 24, 2004 at 06:16:02PM +1100, James Goddard wrote:
> Estimated hours taken: 4
> Branches: main
> 
> Bug fix for Java grade RTTI definitions.
> 
> compiler/rtti_to_mlds.m:
> 	Re-ordered the output of definitions so that subdefinitions always
> 	appear before the definition which uses them.
> 	This is neccessary because in Java, static intializers are performed at
> 	runtime in textual order, and if a definition relies on another static
> 	variable for its constructor but said variable has not been
> 	initialized, then it is treated as `null' by the JVM with no warning.
> 	This change should not effect the other back-ends.
> 
> 
If possible it would be better to append the entries to the beginning of
the list and then reverse them before returning the MLDS_Defns list, so
that the algorithm stays O(N).
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list