[m-rev.] For review: Implement mmake library installation for the Java grade

[Fergus Henderson]

On 18-Feb-2004, James Goddard <goddardjames at yahoo.com> wrote:
> modules.m:
> 	Move code for extracting .class file lists into a form suited for jar
> 	out into make_util.m

s/make_util.m/make.util.m/

IMHO this change is not a good idea, since it creates a circular dependency.
Currently make.m and its submodules depends on other things, but nothing
(apart from mercury_compile.m) depends on make.m.  This is good because
we may in future want to separate out some functionality into separate
libraries.  So I think any functionality which is shared between make.m
(or its submodules) and other parts of the compiler should go in other
parts of the compiler, not in make.m (or its submodules).

In particular for the moment I think list_class_files_for_jar
should go in modules.m, along with create_java_shell_script.

> +++ make.program_target.m	18 Feb 2004 02:14:12 -0000
> @@ -735,7 +735,7 @@
>  	),
>  	globals__io_set_globals(unsafe_promise_unique(Globals)).
>  
> -	% Install the `.a', `.so, `.opt' and `.mih' files
> +	% Install the `.a', `.so, `.jar', `.opt' and `.mih' files

s/`.so/`.so'/

Otherwise that looks good.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------