[m-rev.] For review: bug fix for generating .dv file in grade Java

[Fergus Henderson]

On 12-Feb-2004, James Goddard <goddardjames at yahoo.com> wrote:
> Bug fix for building dv file in grade Java.
> 
> compiler/modules.m:
> 	Fix a bug in generate_dv_file/6 where pattern matching was being
> 	used incorrectly to list .class files of inner modules in Java.

Great, thanks!

Just a couple of minor comments:

> diff -u modules.m modules.m
> --- modules.m	12 Feb 2004 04:36:44 -0000
> +++ modules.m	12 Feb 2004 07:49:13 -0000
> @@ -4408,9 +4408,12 @@
>  	% within the original .java file.  The filenames of all
>  	% these can be matched with `module\$*.class', hence the
>  	% "\\$$*.class" below.
> +	% If none such files exist, GNU Make will use the pattern verbatim,
> +	% so we enclose the pattern in a `wildcard' function to prevent this.

s/none such/no such/

Also, since this is true for all variants of Make, AFAIK,
I suggest s/GNU Make/Make/.

Since `wildcard' is specific to GNU Make, and quite a bit of the other
code in modules.m tries to avoid doing that, please add a comment
"XXX This relies on GNU Make".

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------