[m-rev.] Solver support for abstract equivalence solver types

[Julien Fischer]

On Wed, 1 Dec 2004, Ralph Becket wrote:

> Zoltan Somogyi, Friday, 19 November 2004:
> >
> > Otherwise the diff is fine.
>
> Unfortunately it wasn't: it's taken me nearly two weeks to hunt down
> these bugs!
>
> Here's the LOG and relative diff:
>
>
> Estimated hours taken: 140
> Branches: main
>
> Extend the solver types implementation to handle abstract equivalence solver
> types.
>
> Fix the automatic initialisation of solver type variables to work for atomic
> goals.
>
> compiler/goal_util.m:
> 	Add a version of goal_util__generate_unsafe_cast with two
> 	extra inst parameters (needed because solver types
> 	typically have inst any rather than ground).
>
> compiler/make_hlds.m:
> 	Fixed a bug whereby the declarations for special preds for imported
> 	types were being module qualified using the name of the *importing*
> 	module.  This turns out to be correct for unification and comparison
> 	predicates because they are duplicated in every module that needs
> 	them, but not for solver type initialisation predicates.
>
I think that could be more clearly expressed as:

	Fix a bug wherby the declarations for the initialisation special
	preds ...

If you're just glancing through the log message it looks like there was
a problem with all the special preds, not just the initialisation one.

Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------