[m-rev.] for review: bug fix for try_all/2
Julien Fischer
juliensf at cs.mu.OZ.AU
Fri Dec 10 00:27:36 AEDT 2004
On Fri, 10 Dec 2004, Mark Brown wrote:
> Estimated hours taken: 1
>
> Improve the interface of exception__try_all by separating the output into
> a maybe-exception and a list of solutions. This makes it easier to test
> whether an exception occurred, and removes the need for solutions to be
> wrapped in an exception_result.
>
> This also obviates a bug in the previous implementation/documentation
> of try_all.
>
> Although this change is not backwards compatible, the fact that no one
> reported the existing bug for the last four years suggests that that
> shouldn't be much of an issue.
>
Even so, it would be better to not suddenly delete it. It would
be preferable to stick an obsolete pragma on the old version for now,
along with a comment that this interface is not going to be supported
for much longer.
> NEWS:
> Mention the change.
>
> library/exception.m:
> Modify the interface, implementation and documentation of try_all
> to reflect the above.
>
> Rewrite the documentation of incremental_try_all so as not to refer
> to the old version of try_all. The meaning of incremental_try_all
> is not changed.
>
> tests/hard_coded/exceptions/test_try_all.{m,exp}:
> Update the test case to reflect the new interface.
>
That looks fine otherwise.
Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list