[m-rev.] for review: enable default use of MS Visual C runtime

[Peter Ross]

On Fri, Apr 02, 2004 at 11:33:13AM +0200, Peter Ross wrote:
> On Sun, Mar 28, 2004 at 05:04:06AM +1000, Fergus Henderson wrote:
> > On 25-Mar-2004, Peter Ross <pro at missioncriticalit.com> wrote:
> > > On Tue, Mar 23, 2004 at 04:40:43PM +0100, Peter Ross wrote:
> > > > 
> > > > Estimated hours taken: 2
> > > > Branches: main
> > > > 
> > > > Allow at configure time to build the compiler so that it uses the MS
> > > > Visual C runtime by default.
> > > > 
> > > > This is needed here at MC to build some components which require
> > > > linking against the MS Visual C runtime versus the standard C runtime.
> > > > 
> > > > configure.in:
> > > > 	Add the option --enable-msvcrt so that the 
> > 
> > Shouldn't that be --with-msvcrt?
> > 
> > (See the autoconf documentation on the meaning of "--enable-"
> > and "--with-".)
> > 
> > Also, please document the new configure option in README.MS-VisualC,
> > (and update the other parts of that file if they are out-of-date).
> > 
> 
> diff -u configure.in configure.in
> --- configure.in
> +++ configure.in
> @@ -3616,12 +3616,12 @@
>  #-----------------------------------------------------------------------------#
>  
>  AC_ARG_ENABLE(msvcrt,
> -[  --enable-msvcrt
> +[  --with-msvcrt
>                            use the MS Visual C runtime if using MS C compiler.],
> -ac_msvcrt=yes,ac_msvcrt=no)
> +mercury_cv_msvcrt=yes,mercury_cv_msvcrt=no)
>  
>  AC_MSG_CHECKING(whether to use the MS Visual C Runtime)
> -if test "$ac_msvcrt" = "yes"; then
> +if test "$mercury_cv_msvcrt" = "yes"; then
>  	if test "$ac_microsoft" = "yes"; then
>  		AC_MSG_RESULT(yes)
>  		USE_MSVCRT=yes


===================================================================


Estimated hours taken: 0.25
Branches: main

configure.in:
	Change macro from AC_ARG_ENABLE to AC_ARG_WITH for msvcrt as
	the documentation of the option states that it is a with
	option.


Index: configure.in
===================================================================
RCS file: /home/mercury1/repository/mercury/configure.in,v
retrieving revision 1.389
diff -u -r1.389 configure.in
--- configure.in	2 Apr 2004 08:53:39 -0000	1.389
+++ configure.in	2 Apr 2004 15:38:38 -0000
@@ -3615,7 +3615,7 @@
 
 #-----------------------------------------------------------------------------#
 
-AC_ARG_ENABLE(msvcrt,
+AC_ARG_WITH(msvcrt,
 [  --with-msvcrt
                           use the MS Visual C runtime if using MS C compiler.],
 mercury_cv_msvcrt=yes,mercury_cv_msvcrt=no)

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------