[m-rev.] for review: rewrite mercury_mcpp.cpp in C#

Peter Ross pro at missioncriticalit.com
Thu Oct 30 02:01:03 AEDT 2003


On Wed, Oct 29, 2003 at 03:01:46PM +1100, Peter Moulder wrote:
> The following minor issues were present in the MC++ version.
> 
>                 // the parent constructor sets the error message that
> 		// will be printed.
> 
> Sentences begin with capital letters.  I see no advantage of starting
> with a lowercase letter, and there is a minor disadvantage that the
> maintainer must take a mental detour to consider whether or not the
> beginning of the sentence has been accidentally removed, which distracts
> one's thought.
> 

===================================================================


Estimated hours taken: 0.1
Branches: main

runtime/mercury_mcpp.cs:
	Apply some review comments from pjm.


Index: runtime/mercury_mcpp.cs
===================================================================
RCS file: /home/mercury1/repository/mercury/runtime/mercury_mcpp.cs,v
retrieving revision 1.3
diff -u -r1.3 mercury_mcpp.cs
--- runtime/mercury_mcpp.cs	25 Oct 2003 14:38:00 -0000	1.3
+++ runtime/mercury_mcpp.cs	29 Oct 2003 14:58:57 -0000
@@ -17,8 +17,7 @@
 {
     public SystemException(string Msg) : base(Msg)
     {
-		// the parent constructor sets the error message that
-		// will be printed.
+        // The parent constructor sets the error message that will be printed.
     }
 }
 
@@ -52,7 +51,7 @@
     // These constants are duplicated in library/private_builtin.m.
     // They must be kept sychronized.
 
-	// XXX it would be nice if these could be const or an enum.  But
+	// XXX It would be nice if these could be const or an enum, but
 	// there are some problems with accessing the values from IL if we do
 	// that because neither alternatives seem to define field names we
 	// can reference from IL.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list