[m-rev.] for review: mdbcomp library

Simon Taylor stayl at cs.mu.OZ.AU
Sun Oct 26 19:29:33 AEDT 2003


On 24-Oct-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> For review by Simon. I have already discussed the broad outlines of the change
> with Fergus. Pete may want to have a look to assess its impact on Windows.
> 
> Zoltan.
> 
> Split the existing browser library into two libraries, by making the
> program_representation module into its own library. This is useful because
> the compiler refers to program_representation.m, whose code thus needs to be
> linked into compiler executables even if the compiler isn't compiled with
> debugging enabled. By creating a new library for this module, we avoid any
> chance of the linker dragging in the rest of the modules in the browser
> library. (This is a problem with an upcoming diff.).
> 
> The name of the new library is "mdbcomp", because the intention is that it
> contain code that is shared between the debugger and the compiler. This means
> mostly the definitions of data structures that the compiler generates for the
> debugger, and the predicates that operate on them.

The new library should probably be in a separate directory
to avoid accidental importing the browser from it, although
I'm not really fussed if you don't do that.

If you dont, there should be a comment near the import_module
declarations in browser/program_representation.m stating that
`mdb' and its sub-modules can't be imported.

Other than that, this change looks fine.

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list