[m-rev.] LLDS accurate GC improvements

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Oct 23 15:04:26 AEST 2003


On 23-Oct-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> The indentation here doesn't look consistent.

Hmm, yes, mercury_accurate_gc.c is a perverse mixture of 4- and 8-space
indentation.  I'll fix that (as a separate diff).

> >  #ifdef MR_DEBUG_AGC_SMALL_HEAP
> >    size_t	MR_heap_size =			  52;
> >  #else
> > -  size_t	MR_heap_size =			4096;
> > +  size_t	MR_heap_size =		       32768; /* 16 Mb */
> >  #endif
> 
> That comment looks incorrect ...

Fixed.

> > +** For accurate GC, although we start out with a big heap (32 Mb -- see above),
> 
> That line wraps.

Only when you insert "> " to quote it ;-)

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list