[m-rev.] for review: move towards replacing base_typeclass_infos

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Oct 20 19:48:38 AEST 2003


On 20-Oct-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> On 20-Oct-2003, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > On 20-Oct-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> > > +		Data = type_class_instance(_)
> > > +	->
> > > +		io__write_string("#ifndef MR_STATIC_CODE_ADDRESSES\n", !IO),
> > > +		io__write_string("#error ""type_class_instance " ++
> > > +			"not yet supported without static code addresses""\n",
> > > +			!IO),
> > > +		io__write_string("#endif /* MR_STATIC_CODE_ADDRESSES */\n",
> > > +			!IO)
> > > +	;
> > 
> > It looks to me like an XXX comment is warranted there.
> 
> Why? The #error isn't a good enough warning?

IMHO no, because it won't have the right syntax highlighting ;-)

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list