[m-rev.] for review: term size profiling

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Oct 9 11:18:32 AEST 2003


On 09-Oct-2003, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> 
> On 01-Oct-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> > Index: compiler/mlds_to_il.m
> > ===================================================================
> > @@ -2508,10 +2497,20 @@
> >  		)
> >  	;
> >  		( already_boxed(SrcILType) ->
> > -			( SrcType = mercury_type(_, user_type, _) ->
> > +			(
> > +				SrcType = mercury_type(_, TypeCategory, _),
> > +				% XXX Consider whether this is the right way
> > +				% to handle type_infos, type_ctor_infos,
> > +				% typeclass_infos and base_typeclass_infos.
> > +				( TypeCategory = user_ctor_type
> > +				; is_introduced_type_info_type_category(
> > +					TypeCategory) = yes
> > +				)
> > +			->
> >  				% XXX we should look into a nicer way to
> >  				% generate MLDS so we don't need to do this
> > -				% XXX This looks wrong for --high-level-data. -fjh.
> > +				% XXX This looks wrong for --high-level-data.
> > +				% -fjh.
> >  				Instrs = tree__list([
> >  					comment_node(
> >  						"loading out of an MR_Word"),
> 
> Fergus should probably take a look at this, I don't know much about
> this code.

Zoltan's modifications leave the behaviour of this code unchanged,
so I'm happy with that.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list