[m-rev.] for review: automatically generate all type_ctor_infos on non C backends
Peter Ross
pro at missioncriticalit.com
Thu Nov 20 21:51:55 AEDT 2003
On Thu, Nov 20, 2003 at 11:26:35AM +0100, Peter Ross wrote:
> On Thu, Nov 20, 2003 at 01:40:44PM +1100, Fergus Henderson wrote:
> > On 19-Nov-2003, Peter Ross <pro at missioncriticalit.com> wrote:
> > > Index: compiler/type_util.m
> > ...
> > > + % Remove any of the qualifiers from the builtin types.
> > > +:- func remove_qualifiers_from_the_builtin_types(type) = (type).
> >
> > I suggest s/the qualifiers/the "builtin." qualifiers/
> >
> > The implementation doesn't match the documentation, since
> > the implementation only removes qualifiers from some of the builtin
> > types, not all of them. E.g. it doesn't remove qualifiers from
> > "builtin.c_pointer".
> >
> I am doing some more investigation about this point. It appears that we
> only need to remove the qualifiers for the types which appear in
> private_builtin.m with a unify predicate.
>
It is needed so that the types whose special predicates are defined in
private_builtin.m can typecheck, as the typechecker barfs on these names
if they are qualified.
I have moved the code from type_util to make_hlds and renamed the
predicate adjust_types_with_special_preds_in_private_builtin and added a
comment about type checking.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list