[m-rev.] refactor nondet stack traversal code

Zoltan Somogyi zs at cs.mu.OZ.AU
Tue Nov 11 16:34:11 AEDT 2003


On 08-Nov-2003, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
>  static const char *
> -MR_step_over_nondet_frame(FILE *fp, int level_number, MR_Word *fr)
> +MR_step_over_nondet_frame(MR_Traverse_Nondet_Frame_Func *func,
> +    void *func_data, FILE *dump_fp, int level_number, MR_Word *fr)

For the agc version, you wouldn't want to pass in a FILE *. I don't see
any reason why I/O should happen in MR_step_over_nondet_frame instead
of in func.

The rest looks fine, although I haven't looked at in in detail.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list