[m-rev.] for review: LLDS code gen change for AGC

Zoltan Somogyi zs at cs.mu.OZ.AU
Fri Nov 7 11:04:02 AEDT 2003


On 07-Nov-2003, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> compiler/unify_gen.m:
> compiler/code_info.m:
> compiler/var_locn.m:
> 	When allocating type_infos or typeclass_infos on the heap,
> 	if accurate garbage collection is enabled then ensure that we
> 	reserve a word before the start of the object.

The diff you posted does not use quite the right approach, because your
modification makes the code generator believe that term size profiling
and agc are independent, when in fact both want to reserve an extra word
at offset -1. At the moment, there is no actual conflict, because agc
wants the word only for type-info-like cells and term size profiling
considers all such cells zero sized and doesn't use an extra word for them.
However, it would be nice if the code worked by design and not by accident.

The right fix is best discussed in person.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list