[m-rev.] for review: generalizing dependency_graph.m

[Fergus Henderson]

On 31-May-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> This change is needed by David's constraint-based mode checker, but works
> standalone. Its test is the rest of the constraint-based mode checker.
> 
> Zoltan.
> 
> Preparing for the constraint-based mode checker.
...
> Index: dependency_graph.m
...
> +       % Output a form of the static call graph to a file for use by
> +       % hlds dumps.
>  :- pred dependency_graph__write_dependency_graph(module_info, module_info,
>                                                 io__state, io__state).

The comment here ("for use by hlds dumps") is potentially a bit misleading.
The static call graph output by this predicate is not part of the HLDS
dump files, and is not enabled by the --dump-hlds option; instead,
it gets output to a separate `.dependency_info' file, and whether or
not that file gets written in controlled by a separate
`--show-dependency-info' option.

...
> +dependency_graph__add_pred_proc_nodes([PredId | PredIds], ModuleInfo, Imported,
...
> +		% which are imported (i.e. we don't have any `clauses' for).

s/i.e. we/i.e. which we/

> +dependency_graph__add_pred_nodes([PredId | PredIds], ModuleInfo,
...
> +	% which are imported (i.e. we don't have any `clauses' for).

Likewise.

> +dependency_graph__add_pred_proc_arcs([PredId | PredIds], ModuleInfo, Imported,
...
> +		% which are imported (i.e. we don't have any `clauses' for).

Likewise.

Otherwise, that change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------