[m-rev.] for review: term size profiling

[Fergus Henderson]

On 30-May-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> Here is one you did not identify. Like most of the ones you did identify,
> it is only a couple of hundred lines or so; even I separated them *all* out,
> the main diff would be likely to be over 9000 lines.

Even so, the line count is not directly reflective of the difficulty of
reviewing; it's a lot easier to review a long diff that does just one
thing than a shorter diff that has several different things intermingled.

> browser/declarative_tree.m:
> browser/program_representation.m:
> compiler/prog_rep.m:
> 	Fix a bug: treat unsafe casts as we treat assignment unifications.
> 	We used to treat them as calls, which was wrong, because unlike calls,
> 	unsafe_casts do not generate trace events.
> 
> 	There is no test case, because the compiler does not yet generate
> 	unsafe_casts with option settings that are compatible with declarative
> 	debugging.

How about a test case containing an explicit call to
private_builtin.unsafe_type_cast?

Otherwise that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------