[m-rev.] for review: improve checking of `any' in negated context

Fergus Henderson fjh at cs.mu.OZ.AU
Wed May 28 14:19:25 AEST 2003


On 28-May-2003, David Overton <dmo at cs.mu.OZ.AU> wrote:
> On Wed, May 28, 2003 at 01:28:30PM +1000, Fergus Henderson wrote:
> > Could you please post a new full diff?
> 
> 
> Index: compiler/inst_match.m
> @@ -323,11 +333,16 @@
>  
>  :- type expansions == set(pair(inst)).
>  
> +:- type uniqueness_comparison
> +	--->	match
> +	;	instantiated.

There should be a comment here explaining what those mean.

Otherwise, the code looks fine.

I'm still struggling to convince myself that this change is safe,
i.e. that it doesn't allow any cases which ought to be mode errors.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list