[m-rev.] diff: LIBRARY_TRACE_MINIMUM

[Fergus Henderson]

On 26-May-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> Mmake.common.in:
> library/Mmakefile:
> 	Allow Mmake.params to specify LIBRARY_TRACE_MINIMUM=no, which
> 	allows Mmake.params to also specify the trace level of the library,
> 	and in debugging grades by default compiles the library with
> 	--trace deep.
> 
> 	Include Mmake.library.params if it exists.
...
> Index: library/Mmakefile
...
> @@ -78,9 +79,17 @@
>  # library to be shallow traced, not deep traced, in debugging grades.
>  # This is probably what most users want, and it makes it much easier to
>  # maintain the expected output of the debugging test cases in debugging grades.
> +# However, this can be overridden by setting LIBRARY_TRACE_MINIMUM to no.
>  #
>  # Always generate dependencies for use by `mmc --make'.
> -MCFLAGS += --strict-sequential --trace minimum --generate-mmc-deps \
> +
> +ifeq ($(LIBRARY_TRACE_MINIMUM),no)
> +LIBRARY_TRACE_LEVEL =
> +else
> +LIBRARY_TRACE_LEVEL = --trace minimum
> +endif
> +
> +MCFLAGS += --strict-sequential $(LIBRARY_TRACE_LEVEL) --generate-mmc-deps \
>  		$(INTERMODULE_OPTS) $(ENABLE_TERM_OPTS) $(CHECK_TERM_OPTS)

Your change here inserted new code in between old code and the
comments that refer to it.  The comments about --strict-sequential and
--generate-mmc-deps should be moved to immmediately before the line of
code that they refer to.

Otherwise that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------