[m-rev.] for review: pred_to_bool
Fergus Henderson
fjh at cs.mu.OZ.AU
Thu May 22 13:50:26 AEST 2003
On 22-May-2003, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
>
> NEWS:
> library/bool.m:
> Add `pred_to_bool(P) = ( if P then yes else no )'.
That looks fine.
One very minor thing:
> + % pred_to_bool(P) = ( if P then yes else no ).
...
> +pred_to_bool(P) = ( if P then yes else no ).
As a style issue, I would prefer s/( if/(if/
and s/ )/)/
A quick grep of our sources suggests that these two styles are split
about evenly; it would be good to pick one and standardize on it.
--
Fergus Henderson <fjh at cs.mu.oz.au> | "I have always known that the pursuit
The University of Melbourne | of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh> | -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list