[m-rev.] for review: base_typeclass_info rtti refs

Fergus Henderson fjh at cs.mu.OZ.AU
Thu May 8 16:39:43 AEST 2003


On 08-May-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> > A comment or two here might help.
> 
> I added:
> 
> % All rtti_data data structures and all their components are identified
> % by an rtti_id. For data structures that are part of the description
> % of a single type constructor, we use the rtti_id functor, and make the

After the other change mentioned below, that should be the "ctor_rtti_id"
functor ;-)

(Probably you caught that already, but just in case...)

> > Also, I think it would be clear to name the constructor for the
> > first alternative as "name_rtti_id".
> 
> I am open to alternatives, but name_rtti_id is not an improvement. The
> difference that distinguishes things named with rtti_id(TypeCtor, RttiName)
> from things named with tc_rtti_id(TcRttiName) is the TypeCtor, not the
> RttiName. I am calling that constructor ctor_rtti_id.

OK, I agree ctor_rtti_id is better than name_rtti_id.

> > The comment there about calling error/1 is no longer valid.
> 
> Yes, it is.

Sorry, you're right.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list