[m-rev.] for review: base_typeclass_info rtti refs

[Zoltan Somogyi]

On 08-May-2003, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> Hmmm, this bit change the order in which the data will appear in the the
> RttiDataList.  Previously the rtti_datas for the instance_list came first,
> now the rtti_datas for the classes will come first.  
> 
> I suppose it probably doesn't make any difference either way...

The bootchecks didn't find any problems.

> > +mlds_output_data_name(rtti(RttiId)) -->
> > +	{ rtti__addr_to_string(RttiId, RttiAddrName) },
> 
> I think rtti__addr_to_string would be better named rtti__id_to_string,
> or even better rtti__id_to_c_identifier.

Will do.

> > -			Name = data(base_typeclass_info(_, _))
> > +			Name = data(rtti(tc_rtti_id(_)))
> 
> The code here is inconsistent with the code in mlds_to_c.
> Either this code should be testing
> 
> 		Name = data(rtti(tc_rtti_id(base_typeclass_info(_, _))))
> 
> or the code in mlds_to_c should be changed to match this code.
> It doesn't make any difference right now, since currently
> there is only one kind of tc_rtti_id, but nevertheless these
> two places should be consistent.

I changed the one copy of this code in mlds_to_c that I missed updating
to check only to tc_rtti_id.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------