[m-rev.] for review: brace expansion

[Simon Taylor]

On 07-May-2003, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 06-May-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> > compiler/handle_options.m:
> > 	Perform brace expansion on all options that specify lists of
> > 	directories.
> > 
> > doc/user_guide.texi:
> > 	Document the brace expansion of the values of the affected options.
> > 
> > library/dir.m:
> > 	Add a function expand_braces.
> > 
> > NEWS:
> > 	Mention the new function.
> > 
> > tests/hard_coded/brace.{m,exp}:
> > 	New test case to test the new function.
> > 
> > tests/hard_coded/Mmakefile:
> > 	Enable the new test case.
> 
> That all looks fine.

I disagree. This sort of thing should be left to the shell.
 
> Another alternative would be to add
> 
> 	ifeq($(VERBOSE),yes)
> 	MAYBE_SILENT=@
> 	else
> 	MAYBE_SILENT=
> 	fi
> 
> to Mmake.rules, and have "mmake --verbose" set VERBOSE=yes, then change
> all the rules that produce too much output to use $(MAYBE_SILENT), e.g.

This would be better.

Zoltan, could you please back out your change.

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------