[m-rev.] for review: fix hash table bug

Fergus Henderson fjh at cs.mu.OZ.AU
Fri Mar 21 00:40:15 AEDT 2003


On 20-Mar-2003, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> 
> Estimated hours taken: 1
> Branches: main, release
> 
> NEWS:
> library/hash_table.m:
...
> 	Replace hash_table__search with a function, for consistency 
> 	with the rest of the interface.

That part should not be committed on the release branch.
We shouldn't be changing the library interface in a bug-fix release.

In fact I usually prefer to use predicates rather than functions
for semidet procedures.  This procedure is semidet, unlike all the
other procedures in the interface.  So I think consistency with
the rest of the interface is not a very good argument here.
So personally I'd be inclined to skip this part on the main branch too.
However, if you are very keen to make this change, I won't object.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list