[m-rev.] for review: fix for split_c_files test

Fergus Henderson fjh at cs.mu.OZ.AU
Sat Mar 15 14:07:51 AEDT 2003


For review by stayl.  In particular, Simon, what was the rationale for
the comment "The modules in SPLIT_PROGS should also be in ORDINARY_PROGS
above."?  I don't think that is correct; I think split_c_files should only
be in SPLIT_PROGS, not in ORDINARY_PROGS.  So this diff deletes that comment,
and removes split_c_files from SPLIT_PROGS.

Branches: main
Estimated hours taken: 0.5

tests/hard_coded/Mmakefile:
	Don't run the `split_c_files' test without --split-c-files.
	In particular, don't run it in hlc grades, since it gets
	compiled with `--trace deep', which reports an error in hlc grades.
	
tests/hard_coded/split_c_files.exp:
	Delete this file, since it is no longer used;
	the expected output when compiled with --split-c-files
	is in split_c_files.split.exp.

Workspace: /home/ceres/fjh/mercury
Index: tests/hard_coded/Mmakefile
===================================================================
RCS file: /home/mercury1/repository/tests/hard_coded/Mmakefile,v
retrieving revision 1.193
diff -u -d -r1.193 Mmakefile
--- tests/hard_coded/Mmakefile	3 Mar 2003 03:25:14 -0000	1.193
+++ tests/hard_coded/Mmakefile	15 Mar 2003 03:01:28 -0000
@@ -134,7 +134,6 @@
 	shift_test \
 	solve_quadratic \
 	space \
-	split_c_files \
 	stable_sort \
 	string_alignment \
 	string_alignment_bug \
@@ -320,7 +319,6 @@
 # --split-c-files does not work in the hl* grades (e.g. hlc.gc),
 # because it hasn't yet been implemented yet.
 # The same is true for deep profiling grades and `mmc --make'.
-# The modules in SPLIT_PROGS should also be in ORDINARY_PROGS above.
 ifeq "$(findstring yes,$(MMAKE_USE_MMC_MAKE))$(filter hl% il% java%,$(GRADE))$(findstring profdeep,$(GRADE))" ""
 	SPLIT_PROGS = mapped_module split_c_files
 else
Index: tests/hard_coded/split_c_files.exp
===================================================================
RCS file: tests/hard_coded/split_c_files.exp
diff -N tests/hard_coded/split_c_files.exp
--- tests/hard_coded/split_c_files.exp	25 Jun 2002 15:12:31 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1 +0,0 @@
-[1, 2, 3]

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list