[m-rev.] for review: --debug-threads runtime option

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Mar 4 00:38:26 AEDT 2003


On 03-Mar-2003, Peter Ross <pro at missioncriticalit.com> wrote:
> For fjh to review.

OK, but I'd rather you address my review comments on your previous
stuff before posting any more diffs ;-)

(Specifically I'm talking about the issues with try_wait in extras/
and random number generation in extras/concurrency/philo*.m.)

> Allow one to turn thread debugging on at runtime.
> However only modules which are compiled with MR_DEBUG_THREADS will
> have debugging messages output.

Well, I'm not sure how useful this is.  But at any rate that change looks
mostly harmless.  I do have some comments about the documentation,
though.

> +++ doc/user_guide.texi	3 Mar 2003 12:36:18 -0000
> @@ -6754,6 +6754,13 @@
>  @c --mdb-in-window is for use only by the mdb script, so it's
>  @c not documented here.
>  
> + at sp 1
> + at itemx --debug-threads

s/@itemx/@item/

> + at findex --debug-threads (runtime option)

Also add
	@cindex Debugging Threads
	@cindex Threads, Debugging

> +Output information to stderr about the locking and unlocking occuring in each
> +module which has been compiled with MR_DEBUG_THREADS defined.

What's "stderr"?
And is MR_DEBUG_THREADS supposed to be defined as a predicate or
as a function? ;-)

s/stderr/the standard error stream/
s/MR_DEBUG_THREADS/the C macro symbol @samp{MR_DEBUG_THREADS}/

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list