[m-rev.] for review: library changes for `mmc --make' on Windows

Michael Day mikeday at yeslogic.com
Mon Jun 16 16:50:52 AEST 2003


> dirname("C:\\Foo\\Bar") = "C:\\Foo\\".

Should that last slash be there?
Just quoting from "man 3 dirname":

path           dirname
"/usr/lib"     "/usr"
"/usr/"        "/"
".."           "."

It doesn't appear to be keeping a slash there.
I'm not sure how the Windows functions work, though.

> So that's where they hid that functionality. Thanks for pointing that
> out. I'll redo the basename, dirname, split_name and root_directory
> functions using shlwapi.

Great, that will make it much easier to support paths the same way across
both platforms.

Michael

-- 
YesLogic Prince prints XML!
http://yeslogic.com

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list