[m-rev.] for review: Grade java testing

[Fergus Henderson]

On 10-Jan-2003, Michael Wybrow <mjwybrow at cs.mu.OZ.AU> wrote:
> 
> I do have a couple of questions:
> Why are some entire directories in the test suite disabled? (i.e. Why is
> the recompilation directory not listed in `tests/Mmakefile'.)
> If this is intentional where is it documented?

Good questions.  The "dppd" is also not included.
(All of the other top-level directories are included, though.)

Simon, any idea why the recompilation directory is not being tested?
Do the tests pass?  If so, I suggest that we enable it.
If not, 

Pete, what about the "dppd" directory?
Any objections to my re-enabling the tests in that directory?
(See separate follow-up message.)

> Also, should I modify the Mmakefile
> for such directories to disable their testing in grade java?

IMHO, yes.

> --- tests/general/Mmakefile	28 Nov 2002 09:13:35 -0000	1.49
> +++ tests/general/Mmakefile	10 Jan 2003 07:28:33 -0000
> @@ -71,10 +71,14 @@
>  		map_corresponding \
>  		unused_arg_determinism
>  
> -ifneq "$(findstring profdeep,$(GRADE))" ""
> -	PROGS0 = $(ORDINARY_PROGS)
> +ifneq "$(findstring java,$(GRADE))" ""
> +	PROGS0 =
>  else
> -	PROGS0 = $(ORDINARY_PROGS) $(EXCEPTION_PROGS)
> +	ifneq "$(findstring profdeep,$(GRADE))" ""
> +		PROGS0 = $(ORDINARY_PROGS)
> +	else
> +		PROGS0 = $(ORDINARY_PROGS) $(EXCEPTION_PROGS)
> +	endif
>  endif

There should be a comment here explaining why the tests are disabled
for Java.

Otherwise that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------