[m-rev.] trivial diff: Prevent recursive loop bug in test system

Simon Taylor stayl at cs.mu.OZ.AU
Fri Jan 10 14:44:35 AEDT 2003


On 10-Jan-2003, Michael Wybrow <mjwybrow at cs.mu.OZ.AU> wrote:
> Estimated hours taken: 5
> Branches: main
> 
> Prevent the test system from recursively starting mmake processes if the
> PROGS variable for any test directory contains just whitespace.
> 
> tests/Mmake.common:
> 	Make use of the $(strip string) command to remove whitespace from
> 	the list of tests before we check if this list is empty.
> 
> Index: Mmake.common
> ===================================================================
> RCS file: /home/mercury1/repository/tests/Mmake.common,v
> retrieving revision 1.36
> diff -u -r1.36 Mmake.common
> --- Mmake.common	30 Nov 2002 14:33:15 -0000	1.36
> +++ Mmake.common	10 Jan 2003 02:41:52 -0000
> @@ -230,7 +230,7 @@
>  		$(filter $(THIS_DIR)/%,$(TESTS_TO_RUN))) \
>  		| tr ' ' '\n' | grep -v /)
>  else
> -THIS_DIR_TESTS_TO_RUN := $(TESTS)
> +THIS_DIR_TESTS_TO_RUN := $(strip $(TESTS))
>  endif
>  
>  ifeq ($(THIS_DIR_TESTS_TO_RUN),)

Looks fine.

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list