[m-rev.] for review: reserve-tag flag in type_ctor_info structures

Fergus Henderson fjh at cs.mu.OZ.AU
Sun Feb 23 16:13:12 AEDT 2003


On 11-Feb-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> Add a facility for recording boolean flags in the RTTI structures
> of type constructors. At the moment, the only flag records whether
> the type constructor has a tag value reserved for HAL variables.
> The flag is not used yet.

That change looks good.
Just a couple of issues:

> compiler/rtti_to_mlds.m:
> 	Add the flag field to the type_ctor_info structure for the hlc backend.

The log message there is misleading.  rtti_to_mlds.m is used for all
the MLDS back-ends, not just the hlc backend.  In particular, this
change will cause the .NET back-end to generate the new flag field too.

But there is one other thing which should be done for the .NET
back-end: the definition of MR_DEFINE_BUILTIN_TYPE_CTOR_INFO_FULL()
in runtime/mercury_mcpp.h needs to be updated to include the new field,
so that the builtin type_ctor_infos in the runtime get the new field too.

Otherwise that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list