[m-rev.] for review: fix nested modules bug

[Fergus Henderson]

On 21-Feb-2003, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> 
> Fix a bug reported by Michael Day which caused spurious
> "predicate multiply defined" errors if there were predicates
> `module1.p' and `module2.module1.p'.

That looks fine, I think.

Just one minor comment:

> compiler/goal_util.m:
...
> 	Set the builtin_state field of the call goal returned 
> 	by generate_simple_call correctly.

> Index: compiler/goal_util.m
> +:- import_module ll_backend, ll_backend__code_util.	% for builtin_state.

There should be an XXX comment there -- hlds.* should not import *_backend.*.

Actually it would be better to move builtin_state from
ll_backend.code_util to hlds.hlds_code_util or hlds.goal_util. 
But that can be a separate change.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------