[m-rev.] for review: Changes to time library test cases.

[Fergus Henderson]

On 17-Dec-2003, James Goddard <goddardjames at yahoo.com> wrote:
> Index: Mmakefile
> @@ -347,16 +348,16 @@
>  
>  # We currently don't do any testing in grade java on this directory,
>  # except for java_test.m.
> -ifneq "$(findstring java,$(GRADE))" ""
> -	PROGS = $(JAVA_PROGS)
> -else
> +#ifneq "$(findstring java,$(GRADE))" ""
> +#	PROGS = $(JAVA_PROGS)
> +#else
>  	PROGS = $(ORDINARY_PROGS) $(BROKEN_FOR_LCC_PROGS) \
>  		$(CLOSURE_LAYOUT_PROGS) $(EXCEPTION_PROGS) \
>  		$(BACKEND_PROGS) $(NONDET_C_PROGS) \
>  		$(C_AND_GC_ONLY_PROGS) $(STATIC_LINK_PROGS) \
>  		$(CHAR_REP_PROGS) $(BROKEN_FOR_PROFDEEP)  \
>  		$(FACTT_PROGS) $(DOTNET_PROGS) $(JAVA_PROGS)
> -endif
> +#endif

This fragment of the diff, which enables all of the tests in this
directory in grade "java", was not mentioned in the log message,

This fragment should not be committed, unless all of those tests
actually pass in grade "java" (which I doubt).  Instead, only
those tests which actually pass should be enabled.  Hopefully
that should include time_test and dst_test.

Apart from that, this change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------