[m-rev.] for review: Java implementation of string library

Fergus Henderson fjh at cs.mu.OZ.AU
Fri Dec 12 13:57:30 AEDT 2003


One thing I forgot to mention...

On 12-Dec-2003, James Goddard <goddardjames at yahoo.com> wrote:
> 
> +		try {
> +			FloatVal = java.lang.Double.parseDouble(FloatString);
> +			succeeded = true;
> +		} catch(java.lang.NumberFormatException e) {
> +			if (""nan"".compareTo(FloatString.toLowerCase()) == 0)
> +			{
> +				FloatVal = java.lang.Double.NaN;

There should be a comment here explaining that this code is working
around a bug in some particular Java implementation's implementation
of java.lang.Double.parseDouble(), and identifying the name and release
number of that Java implementation.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list