[m-rev.] for review: fix another termination analysis bug

[Fergus Henderson]

On 05-Dec-2003, Julien Fischer <juliensf at students.cs.mu.OZ.AU> wrote:
> 
> tests/term/Mmakefile:
> 	Set the value of the TESTS variable after setting the value of
> 	PROGS, otherwise the tests will not be run.

The log message is a little bit misleading here.  The real issue is that
the $(TESTS) variable and the $(PROGS) variable that it refers to need
to be fully defined before Mmake.common is included.

> +++ compiler/term_norm.m	5 Dec 2003 02:38:09 -0000
> @@ -146,26 +146,23 @@
>  :- pred find_weights_for_cons(type_ctor::in, list(type_param)::in,
>  	constructor::in, weight_table::in, weight_table::out) is det.
> 
> -% XXX Currently, the weight of a functor is not affected by the presence
> -% of any arguments that are type_info related.  However, the set of
> -% arguments whose sizes should be counted towards the total size of
> -% the term will include any type-info related arguments.
> +% For existentially typed data items the compiler may insert some
> +% type-info related arguments into the functor.  As these have zero-size
> +% they are not counted towards the weight of the functor.
 
The type-info related arguments do not necessarily have zero size,
or even bounded size.  So this comment is not correct.

Otherwise this diff looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------