[m-rev.] for review: updates for opengl binding

[Julien Fischer]

On Sun, 17 Aug 2003, Fergus Henderson wrote:

> > +:- pragma foreign_proc("C", look_at(Ex::in, Ey::in, Ez::in, Cx::in, Cy::in,
> > +		Cz::in, Ux::in, Uy::in, Uz::in, IO0::di, IO::uo),
> > +	[will_not_call_mercury, promise_pure], "
> >  	gluLookAt((GLdouble) Ex, (GLdouble) Ey, (GLdouble) Ez,
> >  		(GLdouble) Cx, (GLdouble) Cy, (GLdouble) Cz,
> >  		(GLdouble) Ux, (GLdouble) Uy, (GLdouble) Uz);
> >  	IO = IO0;
> >  ").
> >
> > -:- pragma c_code(perspective(Fovy::in, Asp::in, N::in, F::in,
> > -		IO0::di, IO::uo), "
> > +:- pragma foreign_proc("C", perspective(Fovy::in, Asp::in, N::in, F::in,
> > +		IO0::di, IO::uo),
> > +	[will_not_call_mercury, promise_pure], "
> >  	gluPerspective((GLdouble) Fovy, (GLdouble) Asp,
> >  		(GLdouble) N, (GLdouble) F);
> >  	IO = IO0;
> >  ").
>
> Are you sure that the `will_not_call_mercury' declarations are correct?
>
Yes, none of the procedures currently implemented in the opengl binding
make calls back to Mercury.


> My preferred layout for "section heading" comments is
>
> 	%---------------------------------------------------------------------%
> 	%
> 	% Heading goes here
> 	%
>
> 	code goes here
>
...
>
> So, I suggest that you change the section headings to use that style.
Done.

> I also propose the following change to coding_standards.html.
>
> Estimated hours taken: 0.25
> Branches: main
>
> compiler/notes/coding_standards.html:
> 	Add some documentation about the layout for section header comments.
>
That looks fine.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------