[m-rev.] for review: lmc.in

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Apr 17 15:14:38 AEST 2003

On 16-Apr-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> +++ tools/lmc.in	2003-04-16 18:33:56.000000000 +1000
> +# that you have built in a workspace. By default, everything that the
> +# compilation # process needs will come from that workspace: the libraries

s/# process/process/

> Index: tools/Mmakefile
> +# Mmakefile for the Mercury tools
> +
> +
> +include $(MERCURY_DIR)/Mmake.common
> +
> +SCRIPTS = lmc

The name "SCRIPTS" is misleading, since almost everything in the
tools directory is a script, but this variable only includes lmc.
It would be a good idea to add a comment and/or change the name.

> +.SUFFIXES: .in
> +
> +.in:
> +	# check to ensure there were no mispelt autoconf variable names
> +	if grep -n '[^$$]@' $@; then false; else true; fi
> +lmc:	$(MERCURY_DIR)/config.status lmc.in

Why define both a generic rule and a special-case rule for lmc?

Also, shouldn't the top-level Mmakefile be modified to run mmake in
the tools directory?

Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe

More information about the reviews mailing list