[m-rev.] for review: dead_pred_elim optimization

Fergus Henderson fjh at cs.mu.OZ.AU
Wed Apr 16 11:00:58 AEST 2003

On 15-Apr-2003, Peter Ross <pro at missioncriticalit.com> wrote:
> Fix a bug in the implementation of predicate_table_restrict where we
> were assuming that because a procedure was not accessible by
> unqualified name that it was also not accessible by partially
> qualified names.
> compiler/hlds_pred.m:
> 	Replace the marker only_accessible_via_fully_qualifed_name 
> 	with the markers not_accessible_by_unqualifed_name and
> 	not_accessible_by_partially_qualified_names.

Isn't this just going to fail in cases involving nested modules
which are nested one more level?

E.g. consider a name "a.b.c.d.e.f", where "a", "b", and "d"
have been imported using "import_module", and "c" and "e" have
been imported using "use_module".  Valid ways to refer to this
name are "c.d.e.f", "b.c.d.e.f", and "a.b.c.d.e.f",
but not "d.e.f", "e.f", or "f".
Will your code handle this case correctly?

Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe

More information about the reviews mailing list