[m-rev.] for review: namespace cleanliness on aral
Fergus Henderson
fjh at cs.mu.OZ.AU
Tue Apr 8 14:16:23 AEST 2003
On 08-Apr-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> +++ runtime/RESERVED_MACRO_NAMES 1 Apr 2003 07:42:12 -0000
> @@ -47,3 +47,11 @@
> # Neither really pollutes the namespace.
> __KERNEL__
> sigcontext_struct
> +#-----------------------------------------------------------------------------#
> +# These are defined on command lines, either in the mgnuc script when calling
> +# gcc or in gcc when calling cc1. Gcc 3.2 doesn't have a means for disabling
> +# the reporting of command line options, so we have to list them here.
> +NO_SIGNALS
> +_GNU_SOURCE
> +__EXTENSIONS__
> +__OPTIMIZE__
I would split this up into two sections, one for NO_SIGNALS (which is
defined by the mgnuc script) and the other for the ones defined by gcc.
There should be an XXX for NO_SIGNALS.
So I suggest something along the lines of this:
# This is defined by the mgnuc script in some grades.
# It is used for configuring the Boehm collector.
# XXX it should have a GC_ prefix.
NO_SIGNALS
# These are defined automatically by GCC -- gcc optionally passes
# them on the command line when calling cc1, depending on the
# exact options which gcc was invoked with. These are not
# namespace polution, since they are in the _[A-Z]* namespace
# which is reserved for the C implementation, and they are being
# defined by the C implementation.
_GNU_SOURCE
__EXTENSIONS__
__OPTIMIZE__
Otherwise that change looks fine.
--
Fergus Henderson <fjh at cs.mu.oz.au> | "I have always known that the pursuit
The University of Melbourne | of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh> | -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list