[m-rev.] diff: namespace cleanliness patterns

Zoltan Somogyi zs at cs.mu.OZ.AU
Sun Sep 29 19:38:16 AEST 2002


Mmake.common.in:
	Update the patterns used in namespace cleanliness checking.

This has already been reviewed by Fergus.

Zoltan.

Index: Mmake.common.in
===================================================================
RCS file: /home/mercury1/repository/mercury/Mmake.common.in,v
retrieving revision 1.66
diff -u -b -r1.66 Mmake.common.in
--- Mmake.common.in	24 Sep 2002 06:54:58 -0000	1.66
+++ Mmake.common.in	26 Sep 2002 04:31:28 -0000
@@ -250,11 +250,15 @@
 # 		normal Mercury source distributions)
 # Exceptions to this policy must be listed in the RESERVED_MACRO_NAMES file
 # in the relevant directory.
+#
+# XXX The base_typeclass_info prefix is allowed only temporarily; it should
+# be fixed by adding a prefix giving the name of the module defining the
+# typeclass.
 
 GEN_MACRO_PREFIX_EXPRS = \
 	-e '^MR_' -e '^MERCURY_' -e '^GC_' -e '^MPS_' -e '^mps_'
 GEN_OBJ_PREFIX_EXPRS = \
-	-e '^MR_' -e '^_entry' -e '^mercury_'
+	-e '^MR_' -e '^_entry' -e '^mercury_'  -e '^base_typeclass_info_' 
 
 ifeq ("$(ALLOW_LIB_PREFIX)","yes")
 LIB_MACRO_PREFIX_EXPRS = \
@@ -329,6 +333,10 @@
 # that the automatically created header file for module x is allowed to have
 # two macros, X_H and X_DECL_GUARD over and above what HEADER_CLEAN_FILTER
 # allows.
+#
+# XXX We should consider deleting the special handling of these macros, and
+# requiring instead that the compiler put MERCURY_ prefixes in front of them,
+# considering them to be honorary submodules of the "mercury" module.
 
 AWK = awk
 
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list