[m-rev.] for review: delete trace level decl

[Zoltan Somogyi]

On 27-Sep-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > doc/user_guide.texi:
> > 	Delete or comment out all mentions of --trace decl and decldebug
> > 	grades.
> 
> It would be good to have an XXX comment there somewhere explaining
> why the commented-out stuff was there (rather than being deleted),
> and why it was commented out.

Done.

> > +++ compiler/layout.m	26 Sep 2002 23:44:29 -0000
> > @@ -56,7 +56,8 @@
> >  			string_table		:: string,
> >  			proc_layout_names	:: list(layout_name),
> >  			file_layouts		:: list(file_layout_data),
> > -			trace_level		:: trace_level
> > +			trace_level		:: trace_level,
> > +			suppressed_events	:: int
> 
> There should be a comment documenting this field (e.g. the one from
> the log message).

I put the comment in mercury_stack_layout.h instead. layout.m directs the
reader there for documentation already.

> It might be nicer to use an equivalence type or a no-tag type, e.g. named
> `suppressed_events' or `encoded_trace_suppress_items', rather than using `int'
> directly.

There are so few references to it, there is not much point.

> > +	set__to_sorted_list(SuppressedEventSet, SuppressedEventList),
> > +	list__foldl(maybe_add_suppressed_event, SuppressedEventList,
> > +		0, SuppressedEventsInt).
> 
> It would be nicer to just use set__fold.

Done.

> > -By default, this is all the usual events,
> > +By default, this is all possible usual events,
> 
> For me, that wording seems rather awkward.
> How about just "By default, this is all possible events,"?

That's what I intended to put there.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------