[m-rev.] diff: MDB and HOME

Zoltan Somogyi zs at cs.mu.OZ.AU
Mon Sep 2 13:39:17 AEST 2002


This addresses Simon's review comments of an earlier change.

Zoltan.

Centralize the MDB make variable in tests/Mmake.common.

tests/Mmake.common:
	Define MDB here, and make it override $HOME.

tests/debugger/Mmakefile:
tests/debugger/declative/Mmakefile:
	Delete the definition of MDB.

tools/bootcheck:
	Delete the overriding of $HOME.

cvs diff: Diffing tests
Index: tests/Mmake.common
===================================================================
RCS file: /home/mercury1/repository/tests/Mmake.common,v
retrieving revision 1.27
diff -u -r1.27 Mmake.common
--- tests/Mmake.common	2002/08/30 06:07:23	1.27
+++ tests/Mmake.common	2002/08/30 07:42:56
@@ -49,6 +49,16 @@
 # deep profiling.
 RUN_RECOMPILATION_TESTS=yes
 
+# We avoid picking up parameter settings from $HOME/.mdbrc that could
+# cause spurious differences between the outputs of the debugger test
+# cases and their expected outputs.
+
+# We suppress the printing of the banner, because different workspaces
+# may get different version numbers printed in it. This would otherwise be
+# the source of irrelevant difference between the actual and expected outputs.
+
+MDB = HOME=/nonexistent MERCURY_SUPPRESS_MDB_BANNER=yes mdb
+
 #-----------------------------------------------------------------------------#
 
 # .PRECIOUS: %.c %.o %_init.c
cvs diff: Diffing tests/benchmarks
cvs diff: Diffing tests/debugger
Index: tests/debugger/Mmakefile
===================================================================
RCS file: /home/mercury1/repository/tests/debugger/Mmakefile,v
retrieving revision 1.82
diff -u -r1.82 Mmakefile
--- tests/debugger/Mmakefile	2002/09/01 06:05:20	1.82
+++ tests/debugger/Mmakefile	2002/09/01 07:11:07
@@ -4,14 +4,6 @@
 
 #-----------------------------------------------------------------------------#
 
-# We suppress the printing of the banner, because different workspaces
-# may get different version numbers printed in it. This would otherwise be
-# the source of irrelevant difference between the actual and expected outputs.
-
-MDB = MERCURY_SUPPRESS_MDB_BANNER=yes mdb
-
-#-----------------------------------------------------------------------------#
-
 RETRY_PROGS = \
 	all_solutions			\
 	browser_test			\
cvs diff: Diffing tests/debugger/declarative
Index: tests/debugger/declarative/Mmakefile
===================================================================
RCS file: /home/mercury1/repository/tests/debugger/declarative/Mmakefile,v
retrieving revision 1.39
diff -u -r1.39 Mmakefile
--- tests/debugger/declarative/Mmakefile	2002/08/29 16:15:53	1.39
+++ tests/debugger/declarative/Mmakefile	2002/08/30 01:27:38
@@ -4,14 +4,6 @@
 
 #-----------------------------------------------------------------------------#
 
-# We suppress the printing of the banner, because different workspaces
-# may get different version numbers printed in it. This would otherwise be
-# the source of irrelevant difference between the actual and expected outputs.
-
-MDB = MERCURY_SUPPRESS_MDB_BANNER=yes mdb
-
-#-----------------------------------------------------------------------------#
-
 DECLARATIVE_PROGS=		\
 	aadebug			\
 	app			\
cvs diff: Diffing tools
Index: tools/bootcheck
===================================================================
RCS file: /home/mercury1/repository/mercury/tools/bootcheck,v
retrieving revision 1.136
diff -u -r1.136 bootcheck
--- tools/bootcheck	2002/08/21 11:27:56	1.136
+++ tools/bootcheck	2002/08/22 10:06:06
@@ -974,12 +974,6 @@
 	MERCURY_DEBUGGER_INIT=$root/scripts/test_mdbrc
 	export MERCURY_DEBUGGER_INIT
 
-	# Avoid picking up parameter settings from $HOME/.mdbrc that could
-	# cause spurious differences between the outputs of the debugger test
-	# cases and their expected outputs.
-	HOME=/nonexistent
-	export HOME
-
 	if test "$test_grade" != ""
 	then
 		test_grade_opt="GRADE=$test_grade"
cvs diff: Diffing trace
cvs diff: Diffing util
cvs diff: Diffing vim
cvs diff: Diffing vim/after
cvs diff: Diffing vim/ftplugin
cvs diff: Diffing vim/syntax
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list