[m-rev.] for review: make --c-debug work with MSVC
Fergus Henderson
fjh at cs.mu.OZ.AU
Thu Oct 31 03:27:07 AEDT 2002
On 30-Oct-2002, Peter Ross <pro at missioncriticalit.com> wrote:
> Make --c-debug work correctly when using MSVC as your C compiler.
...
> +++ scripts/ml.in 30 Oct 2002 16:04:26 -0000
> @@ -436,8 +436,17 @@
> true) demangle=false ;;
> esac
>
> +# Determine whether to link the executable with debugging symbols when using
> +# MSVC.
> +if [ $strip = "false" -a $COMPILER = "cl" ]
> +then
> + DEBUG_FLAG="/DEBUG"
> +else
> + DEBUG_FLAG=""
> +fi
It would be nicer to put that code next to the other code dealing
with $strip.
Otherwise that patch looks fine.
--
Fergus Henderson <fjh at cs.mu.oz.au> | "I have always known that the pursuit
The University of Melbourne | of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh> | -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list