[m-rev.] diff: disable tests/hard_coded/special_char for IL

Fergus Henderson fjh at cs.mu.OZ.AU
Wed Oct 23 23:41:43 AEST 2002


Estimated hours taken: 0.5
Branches: main

hard_coded/Mmakefile:
	Disable the special_char test for IL and Java grades, since
	the test case makes non-portable assumptions which are not
	true for those grades.

	Also fix a bug in one of my earlier changes:
	redirect stderr when invoking $(MGNUC) to check for lcc.
	This avoids spurious error messages when invoking mmake
	in this directory.

Workspace: /mnt/roy/fjh/traveller/mercury
Index: tests/hard_coded/Mmakefile
===================================================================
RCS file: /home/mercury1/repository/tests/hard_coded/Mmakefile,v
retrieving revision 1.172
diff -u -d -r1.172 Mmakefile
--- tests/hard_coded/Mmakefile	2002/10/23 06:20:38	1.172
+++ tests/hard_coded/Mmakefile	2002/10/23 13:38:31
@@ -128,7 +128,6 @@
 	shift_test \
 	solve_quadratic \
 	space \
-	special_char \
 	split_c_files \
 	stable_sort \
 	string_alignment \
@@ -159,7 +158,7 @@
 	write_reg2
 
 # These tests trigger a bug in lcc
-ifeq "$(findstring lcc,$(shell $(MGNUC) -v))" "lcc"
+ifeq "$(findstring lcc,$(shell $(MGNUC) -v 2>&1))" "lcc"
   BROKEN_FOR_LCC_PROGS =
 else
   BROKEN_FOR_LCC_PROGS = \
@@ -172,6 +171,15 @@
 	copy_pred \
 	copy_pred_2
 
+# This test requires the implementation's representation of characters
+# to be the same as their representation in files, which is not true
+# for the IL and Java back-ends, which use Unicode internally.
+ifeq "$(filter il% java%,$(GRADE))" ""
+	CHAR_REP_PROGS = special_char
+else
+	CHAR_REP_PROGS =
+endif
+
 # We do not pass the following tests at all:
 #
 # XXX var_not_found -- mode error in automatically generated unification
@@ -256,7 +264,7 @@
 endif
 
 PROGS = $(ORDINARY_PROGS) $(BROKEN_FOR_LCC_PROGS) $(CLOSURE_LAYOUT_PROGS) \
-	$(EXCEPTION_PROGS) $(BACKEND_PROGS) $(NONDET_C_PROGS)
+	$(EXCEPTION_PROGS) $(BACKEND_PROGS) $(NONDET_C_PROGS) $(CHAR_REP_PROGS)
 
 # --split-c-files does not work in the hl* grades (e.g. hlc.gc),
 # because it hasn't yet been implemented yet.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list