[m-rev.] for review: build boehmgc with MSVC

[Fergus Henderson]

On 22-Oct-2002, Peter Ross <pro at missioncriticalit.com> wrote:
> Compile the boehmgc collector with the correct makefile when using the
> MS Visual C compiler.  This fixes the problem introduced by fjh's
> previous change to make merging to a new boehmgc collector easier.

That looks fine.

> configure.in:
> 	Set USING_MICROSOFT_CL_COMPILER when we are using the MS
> 	compiler.
> 	Delete BOEHMGC_MAKEFILE.

Normally, autoconf variables needs to be mentioned in bindist/build_vars.in
or bindist/bindist.configure.in.  In this particular case, it doesn't,
since USING_MICROSOFT_CL_COMPILER is currently only used during the build,
not after installation.  But this is somewhat fragile... someone might
add a new use of USING_MICROSOFT_CL_COMPILER in scripts/Mmake.vars and
wonder why the binary distribution broke.  So it may be worth
documenting near the definition of USING_MICROSOFT_CL_COMPILER
that it must only be used during the build, not by anything which
will get installed, unless those files are updated.

> +++ boehm_gc/Mmakefile	22 Oct 2002 13:42:18 -0000
> +ifeq ("$(USING_MICROSOFT_CL_COMPILER)", "yes")
...
> +clean_local:
> +	rm -f *.obj gc.lib libgc.$A libpar_gc.$A libpar_gc.dll
> +
> +else
...
>  clean_local:
>  	MAKEFLAGS=""; export MAKEFLAGS; \
>  	$(MAKE) $(BOEHMGC_MAKEFILE) $(MMAKEFLAGS) clean
>  	rm -rf Release
>  	rm -f libgc.$A libgc.so libpar_gc.$A libpar_gc.dll

Why does clean_local do "rm -rf Release" only in the !USING_MICROSOFT_CL_COMPILER
case?

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------