[m-rev.] trivial diff: add comment for visible_modules bug

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Oct 22 23:33:55 AEST 2002


The following bug results in occaisional misleading error messages from
typecheck.m.  I think it could also result in problems with
--smart-recompilation not recompiling things when it ought to.

Simon, would you be willing to have a look at this one?

Estimated hours taken: 0.1
Branches: main

compiler/hlds_module.m:
	Add an XXX comment pointing out a bug is `visible_module'.

Workspace: /home/ceres/fjh/mercury
Index: compiler/hlds_module.m
===================================================================
RCS file: /home/mercury1/repository/mercury/compiler/hlds_module.m,v
retrieving revision 1.76
diff -u -d -r1.76 hlds_module.m
--- compiler/hlds_module.m	1 Aug 2002 11:52:17 -0000	1.76
+++ compiler/hlds_module.m	22 Oct 2002 13:28:11 -0000
@@ -245,6 +245,8 @@
 
 	% The visible modules are the current module, any
 	% imported modules, and any ancestor modules.
+	% XXX BUG: it should also include modules imported
+	% from ancestor modules!
 	% It excludes transitively imported modules (those
 	% for which we read `.int2' files).
 :- pred visible_module(module_name, module_info).
-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list