[m-rev.] for review: installing the default grade

[Fergus Henderson]

On 11-Oct-2002, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> Index: Mmakefile
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/Mmakefile,v
> retrieving revision 1.87
> diff -u -b -r1.87 Mmakefile
> --- Mmakefile	23 Sep 2002 17:22:26 -0000	1.87
> +++ Mmakefile	4 Oct 2002 22:46:24 -0000
> @@ -425,7 +425,37 @@
>  	# runs the newly installed compiler, rather than using the
>  	# bootstrap compiler.
>  	#
> -	+for grade in x $(LIBGRADES); do \
> +	# The install_grades target does not install the libraries in grade
> +	# $(GRADE), since these should have been installed earlier by the
> +	# install_main target. To compensate for this, the configure script
> +	# deletes the value that $(GRADE) has at configure time from
> +	# $(LIBGRADES), to prevent install_grades installing that grade twice.

This comment is not quite correct; after my recent rewrite of the grade
selection code in configure.in, $(GRADE) is now only deleted from
$(LIBGRADES) if it is equal to $(DEFAULT_GRADE).

But apart from that, this change is fine.

The same issue arises for Mmake's automatically generated installation targets
(lib%.install in scripts/Mmake.rules).  It would be a good idea to fix
that one at the same time.

I think it would be more elegant for $(LIBGRADES) to always include all the
grades, and just have a test in the body of the loop, 
i.e.

	for grade in x $(LIBGRADES); do
	    if test $grade = x; then
	    	:
	    elif test $grade = $GRADE then
	   	echo "Skipping already-installed grade $grade"
	    else
	    	... code to install as usual
	    fi
	done

or just

	for grade in x $(LIBGRADES); do
	    if test $grade != x -a $grade != $(GRADE); then
	    	... code to install as usual
	    fi
	done

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------