[m-rev.] diff: apply very old stayl review comments

Peter Ross pro at missioncriticalit.com
Fri Nov 29 23:03:50 AEDT 2002


Hi,


===================================================================


Estimated hours taken: 0.25
Branches: main, release

compiler/make.module_target.m:
compiler/modules.m:
	Address some review comments from stayl from a long time ago.

Index: make.module_target.m
===================================================================
RCS file: /home/mercury1/repository/mercury/compiler/make.module_target.m,v
retrieving revision 1.17
diff -u -r1.17 make.module_target.m
--- make.module_target.m	30 Oct 2002 13:31:48 -0000	1.17
+++ make.module_target.m	29 Nov 2002 11:55:49 -0000
@@ -584,8 +584,7 @@
 	    ),
 
 	    { ( CompilationTarget = c ; CompilationTarget = asm ) ->
-		Names = list__map((func(MI) = MI ^ module_name),
-				ModuleImportsList),
+		Names = SourceFileModuleNames,
 	    	HeaderTargets = make_target_list(Names, c_header(mh))
 				++ HeaderTargets0
 	    ;
Index: modules.m
===================================================================
RCS file: /home/mercury1/repository/mercury/compiler/modules.m,v
retrieving revision 1.253
diff -u -r1.253 modules.m
--- modules.m	15 Nov 2002 04:50:25 -0000	1.253
+++ modules.m	29 Nov 2002 11:55:51 -0000
@@ -4019,7 +4019,8 @@
 	io__write_string(DepStream, MakeVarName),
 	io__write_string(DepStream, ".mhs = "),
 	( { Target = c ; Target = asm } ->
-		write_dependencies_list(Modules, ".mh", DepStream)
+		write_compact_dependencies_list(Modules,
+				"", ".mh", Basis, DepStream)
 	;
 		[]
 	),

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list