[m-rev.] for review: fix rtti get_arg bugs for il grade

[Fergus Henderson]

On 27-Nov-2002, Peter Ross <pro at missioncriticalit.com> wrote:
> fjh wrote:
> > On 26-Nov-2002, Peter Ross <peter.ross at miscrit.be> wrote:
> > > Fix bugs in get_arg when used with high-level data.
> > >
> > > library/rtti_implementation.m:
> > > Fix a bug where the number of extra args in a functor where
> >
> > s/where/were/
> >
> > > being calculated according to whether or not a particular arg
> > > of that functor was an existentially quantified type variable,
> > > instead of just calculating the number of extra args from the
> > > information in the exist_info for that functor.
> > > Fix a bug where with high-level data the type of the secondary
> > > tag doesn't matter for determing the offset to find a functors
> > > arg.
> >
> > Test case?
>
> cd tests/hard_coded/typeclasses
> mmake GRADE=il existential_rtti.log

OK.  That information should be included in the log message.

> > > +:- pred high_level_data is semidet.
> > > +:- pragma foreign_proc("MC++", high_level_data,
...
> > > +high_level_data :-
> > > + fail.
> >
> > That is wrong for the `hl*' and `java' grades.
> >
> > Also, I think `fail' needs to be `semidet_fail' to avoid
> > a determinism warning for non-il grades.
>
> Yes I am going to change this to a
> private_builtin__sorry("high_level_data").

That will still result in a determinism warning.
Make it "semidet_succeed, private_builtin__sorry(...)".

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------