[m-rev.] for review: fix `mmc --make' signal bugs

[Fergus Henderson]

That diff looks fine, but while reviewing it I spotted a bug
in the existing code that you were modifying:

On 21-Nov-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> 
> +++ compiler/process_util.m	21 Nov 2002 00:46:43 -0000
> @@ -193,7 +193,7 @@
>  
>  	MR_incr_hp_msg(SigintHandler,
>  		MR_bytes_to_words(sizeof(MR_signal_action)),
> -		MR_PROC_LABEL, ""make.util.signal_action/0"");
> +		MR_PROC_LABEL, ""libs.process_util.signal_action/0"");

There is no guarantee that the memory allocated by MR_incr_hp_msg()
will be sufficiently aligned to hold a value of type MR_signal_action.

It's probably best to address this one as a separate change,
so for now, could you please add an XXX comment for that?

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------