[m-rev.] for review: fix .NET compiler command lines

[Simon Taylor]

On 13-Nov-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > @@ -246,7 +246,7 @@
> >  	{ join_string_list(CSCFlagsList, "", "", " ", CSCFlags) },
> >  	globals__io_lookup_bool_option(target_debug, Debug),
> >  	{ Debug = yes ->
> > -		DebugOpt = "" % XXX
> > +		DebugOpt = "/debug+ /debug:full"
> 
> That's missing a trailing space, isn't it?
> Oh, I see below that there is an extra space before
> the thing which follows DebugOpt.  Better to remove
> that and put the trailing space here.

Done.
 
> Also, have you tested this?  There seem to be problems mixing C# files
> compiled with debugging with IL or MC++ files compiled with debugging in
> the same assembly.  Maybe this is OK, because I think only the standard
> library gets put in a single assembly...  but I would not be confident
> about this unless it has been tested.  If you haven't tested it on .NET,
> I think it may be best to leave the C# debugging option as empty for now.

Done.

I've just noticed that library/Mmakefile has two different sets of
debugging options for .NET:

	# Turn this on if you wish to enable .NET debugging.
	# But see the comments below about the install_debug_library target.
	DEBUG_MS_ILASMFLAGS=
	#DEBUG_MS_ILASMFLAGS=/debug
	#DEBUG_MS_CLFLAGS=/Zi
	#DEBUG_MS_CSCFLAGS=/debug

and later

	# To build the .NET library with debugging information, add
	# the following to ../Mmake.params:
	#
	#       EXTRA_MS_ILASMFLAGS=/debug
	#       EXTRA_CSCFLAGS=/debug+ /debug:full
	#       EXTRA_MS_CLFLAGS=/Zi
	#

Simon.

--- compile_target_code.m	2002/11/13 03:23:58	1.1
+++ compile_target_code.m	2002/11/13 03:26:14
@@ -246,7 +246,11 @@
 	{ join_string_list(CSCFlagsList, "", "", " ", CSCFlags) },
 	globals__io_lookup_bool_option(target_debug, Debug),
 	{ Debug = yes ->
-		DebugOpt = "/debug+ /debug:full"
+		% XXX This needs testing before it can be enabled
+		% (see the comments for install_debug_library in
+		% library/Mmakefile).
+		% DebugOpt = "/debug+ /debug:full "
+		DebugOpt = ""
 	;
 		DebugOpt = ""
 	},
@@ -258,7 +262,7 @@
 	 	(func(DLLDir) = ["/lib:", DLLDir, " "]), DLLDirs))) },
 
 	{ string__append_list([CSC, " -CLR ", DebugOpt,
-		" /t:library ", DLLDirOpts, CSCFlags,
+		"/t:library ", DLLDirOpts, CSCFlags,
 		" /out:", DLLFileName, " ", CSharpFileName], Command) },
 	invoke_system_command(ErrorStream, verbose_commands,
 		Command, Succeeded).
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------